Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segment Replication] Remove primary targets from replication tracker #11011

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[Segment Replication] Remove primary targets from replication tracker #11011

merged 1 commit into from
Oct 31, 2023

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Oct 31, 2023 •
edited
Loading

Description

Removes primary relocation targets from replication tracker.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89
[Segment Replication] Remove primary targets from replication tracker
5ebd5a7 
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 5ebd5a7

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@dreamer-89 dreamer-89 added the backport 2.x Backport to 2.x branch label Oct 31, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

#10704

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Merging #11011 (5ebd5a7) into main (9d85e56) will decrease coverage by 0.09%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##               main   #11011      +/-   ##
============================================
- Coverage     71.22%   71.14%   -0.09%     
+ Complexity    58732    58671      -61     
============================================
  Files          4872     4872              
  Lines        276671   276679       +8     
  Branches      40206    40210       +4     
============================================
- Hits         197064   196842     -222     
- Misses        63187    63364     +177     
- Partials      16420    16473      +53
Files Coverage Δ
...org/opensearch/index/seqno/ReplicationTracker.java 68.69% <87.50%> (-0.36%) ⬇️

... and 440 files with indirect coverage changes

@dreamer-89 dreamer-89 merged commit 9c65350 into opensearch-project:main Oct 31, 2023
60 of 116 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 31, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 31, 2023
@github-actions
[Segment Replication] Remove primary targets from replication tracker (…
50a5006 
…#11011)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit 9c65350)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89 pushed a commit that referenced this pull request Oct 31, 2023
@opensearch-trigger-bot @github-actions
[Segment Replication] Remove primary targets from replication tracker (…
4fd7ee8 
…#11011) (#11012)

(cherry picked from commit 9c65350)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@dreamer-89 @shiv0408
[Segment Replication] Remove primary targets from replication tracker (…
c192acd 
…opensearch-project#11011)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mch2 mch2 mch2 approved these changes

@Rishikesh1159 Rishikesh1159 Rishikesh1159 approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@reta reta Awaiting requested review from reta reta is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@setiah setiah Awaiting requested review from setiah

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamer-89 @mch2 @Rishikesh1159